Mark kernels as internal #4098
Merged
Mark kernels as internal #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2024
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
0eea343 to
fd90f62
Compare
robertmaynard
added
bug
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
3 times, most recently
from
20cb20b to
3d2f01d
Compare
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
2 times, most recently
from
98230b2 to
a931ba2
Compare
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
2066ce1 to
a7aa7d0
Compare
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
7caf745 to
6e6073d
Compare
|
/ok to test |
BradReesWork
approved these changes
Mar 8, 2024
seunghwak
approved these changes
Mar 8, 2024
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
549ce67 to
28e6e8b
Compare
|
/merge |
AyodeAwe
approved these changes
Mar 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream consumers of static built versions of RAPIDS C++ projects have encountered runtime issues due to multiple instances of the same kernel existing in different DSOs.
To resolve this issue we need to ensure that all CUDA kernels in all RAPIDS libraries need to be have internal linkage ( static for projects using whole compilation, attribute((visibility("hidden"))) for header libraries / separable compilation ).
This updates all cugraph kernels to have internal linkage, and adds a CI job to verify that no new kernels are added with external linkage.